Updates the overlay metacard transformer so it will reverse counterclockwise coordinates to clockwise before manipulating the image. This is necessary because the image manipulation code assumes the coordinates are clockwise.
This metacard's location is a box with its coordinates in counterclockwise order. Open Intrigue and search for it, then overlay the thumbnail on the map. It should be rotated 90 degrees to the left, since the lower-left corner of the box (the first point of the WKT) will correspond to the top-left corner of the image when the coordinates are in clockwise order.
Checklist:
[ ] Documentation Updated
[ ] Update / Add Threat Dragon models
[x] Update / Add Unit Tests
[ ] Update / Add Integration Tests
Notes on Review Process
Please see Notes on Review Process for further guidance on requirements for merging and abbreviated reviews.
Review Comment Legend:
✏️ (Pencil) This comment is a nitpick or style suggestion, no action required for approval. This comment should provide a suggestion either as an in line code snippet or a gist.
❓ (Question Mark) This comment is to gain a clearer understanding of design or code choices, clarification is required but action may not be necessary for approval.
❗ (Exclamation Mark) This comment is critical and requires clarification or action before approval.
What does this PR do?
Updates the overlay metacard transformer so it will reverse counterclockwise coordinates to clockwise before manipulating the image. This is necessary because the image manipulation code assumes the coordinates are clockwise.
Who is reviewing it?
@millerw8 @maiiiiiiii @kcwire @jlcsmith
How should this be tested?
Ingest the following metacard:
This metacard's location is a box with its coordinates in counterclockwise order. Open Intrigue and search for it, then overlay the thumbnail on the map. It should be rotated 90 degrees to the left, since the lower-left corner of the box (the first point of the WKT) will correspond to the top-left corner of the image when the coordinates are in clockwise order.
Checklist:
Notes on Review Process
Please see Notes on Review Process for further guidance on requirements for merging and abbreviated reviews.
Review Comment Legend: