codice / ddf

DDF Distributed Data Framework - an open source, modular integration framework.
http://ddf.codice.org
Other
132 stars 181 forks source link

DDF-6386 Add support for source id and metacard type for csv metacard transforms #6707

Closed derekwilhelm closed 1 year ago

derekwilhelm commented 2 years ago

What does this PR do?

Forward port and conflict resolution of #6387 :

Downstream projects need to create CSV exports that include the source identifier and metacard type name. The current code only supports exporting data that is contained in a metacard attribute. However, the source identifier and metacard type name are stored separately from the attributes.

This PR also creates a constant in MetacardType for the string "metacard-type", which was being defined multiple times in DDF and in downstream projects.

This PR also includes a forward port of #6501 which adds UTC dates when exporting metacards in CSV format.

Who is reviewing it?

@glenhein @jlcsmith @jrnorth

Select relevant component teams:

@codice/core-apis @codice/data

Ask 2 committers to review/merge the PR and tag them here.

@andrewkfiedler @clockard

How should this be tested?

Build with a downstream project that provides a UI capable of creating a CSV export. The export should include the source id and metacard type. Make sure that the exported data includes the correct values for these fields.

Export a metacard as a CSV file. Verify that the generated CSV uses UTC dates. For example: image

Any background context you want to provide?

What are the relevant tickets?

Fixes: #6386

Screenshots

Checklist:

Notes on Review Process

Please see Notes on Review Process for further guidance on requirements for merging and abbreviated reviews.

Review Comment Legend:

derekwilhelm commented 2 years ago

build now

cxddfbot commented 2 years ago

Internal build has been started, your results will be available at build completion.

cxddfbot commented 2 years ago

Build SUCCESS See the job results in legacy Jenkins UI or in Blue Ocean UI.

derekwilhelm commented 2 years ago

build now

cxddfbot commented 2 years ago

Internal build has been started, your results will be available at build completion.

cxddfbot commented 2 years ago

Build SUCCESS See the job results in legacy Jenkins UI or in Blue Ocean UI.

derekwilhelm commented 2 years ago

build now

cxddfbot commented 2 years ago

Internal build has been started, your results will be available at build completion.

cxddfbot commented 2 years ago

Build SUCCESS See the job results in legacy Jenkins UI or in Blue Ocean UI.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within 7 days. Thank you for your contributions.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within 7 days. Thank you for your contributions.