[2.19.x] G-20606 Added a converter for lineString which supports posList over pos

millerw8 commented 2 years ago

What does this PR do?

Adds a converter for CSW getRecords requests to transform lineString queries to posList (in lieu of pos[]) when converted JTS to GML 3.1.1.

Who is reviewing it?

@jrnorth @kcwire

Select relevant component teams:

Ask 2 committers to review/merge the PR and tag them here.

How should this be tested?

Set up a CSW federated Source, select usePosList true, execute a lineString query to that source, and confirm the outbound xml represents the LineString geometry as a posList instead of a pos[]... e.g.

<posList>1 2 3 4 5 6</posList>

instead of

<pos>1 2</pos>
<pos>3 4</pos>
<pos>5 6</pos>

Any background context you want to provide?

There was already logic in place to do this for LinearRing and Polygons (which use LinearRings), but nothing that enforced this for LineString. Adding this makes LineString behave consistently with the other shapes.

What are the relevant tickets?

Fixes: #____

Screenshots

Checklist:

[ ] Documentation Updated
[ ] Update / Add Threat Dragon models
[ ] Update / Add Unit Tests
[ ] Update / Add Integration Tests

Notes on Review Process

Please see Notes on Review Process for further guidance on requirements for merging and abbreviated reviews.

Review Comment Legend:

✏️ (Pencil) This comment is a nitpick or style suggestion, no action required for approval. This comment should provide a suggestion either as an in line code snippet or a gist.
❓ (Question Mark) This comment is to gain a clearer understanding of design or code choices, clarification is required but action may not be necessary for approval.
❗ (Exclamation Mark) This comment is critical and requires clarification or action before approval.

CLAassistant commented 2 years ago

All committers have signed the CLA.

kcwire commented 1 year ago

build now

millerw8 commented 1 year ago

build now

cxddfbot commented 1 year ago

Internal build has been started, your results will be available at build completion.

cxddfbot commented 1 year ago

Build SUCCESS See the job results in legacy Jenkins UI or in Blue Ocean UI.

codice / ddf