codice / ddf

DDF Distributed Data Framework - an open source, modular integration framework.
http://ddf.codice.org
Other
132 stars 181 forks source link

Prevent AND queries containing invalid filters from running against WFS 1.1.0 sources #6745

Closed jrnorth closed 1 year ago

jrnorth commented 1 year ago

Forward port of https://github.com/codice/ddf/pull/6736

What does this PR do?

Now, the WfsFilterDelegate will return null when ANDing filters and at least one is null. This means any AND group will be dropped if it contains a feature property not understood by the source being queried. If this results in no filter for the query at all, then it will not be run against the source.

Also, note that test coverage did not actually decrease with this change. The instruction coverage was updated to reflect its true value; LenientLimit has prevented this from failing the build.

Who is reviewing it?

@derekwilhelm
@alexabird

Select relevant component teams:

@codice/core-apis @codice/ogc

Ask 2 committers to review/merge the PR and tag them here.

@glenhein
@jlcsmith

How should this be tested?

Test in downstsream

Checklist:

Notes on Review Process

Please see Notes on Review Process for further guidance on requirements for merging and abbreviated reviews.

Review Comment Legend:

jrnorth commented 1 year ago

build now

cxddfbot commented 1 year ago

Internal build has been started, your results will be available at build completion.

cxddfbot commented 1 year ago

Build SUCCESS See the job results in legacy Jenkins UI or in Blue Ocean UI.