Now, the WfsFilterDelegate will return null when ANDing filters and at least one is null. This means any AND group will be dropped if it contains a feature property not understood by the source being queried. If this results in no filter for the query at all, then it will not be run against the source.
Also, note that test coverage did not actually decrease with this change. The instruction coverage was updated to reflect its true value; LenientLimit has prevented this from failing the build.
Who is reviewing it?
@derekwilhelm
@alexabird
Select relevant component teams:
@codice/core-apis
@codice/ogc
Ask 2 committers to review/merge the PR and tag them here.
@glenhein
@jlcsmith
How should this be tested?
Test in downstsream
Checklist:
[ ] Documentation Updated
[ ] Update / Add Threat Dragon models
[x] Update / Add Unit Tests
[ ] Update / Add Integration Tests
Notes on Review Process
Please see Notes on Review Process for further guidance on requirements for merging and abbreviated reviews.
Review Comment Legend:
✏️ (Pencil) This comment is a nitpick or style suggestion, no action required for approval. This comment should provide a suggestion either as an in line code snippet or a gist.
❓ (Question Mark) This comment is to gain a clearer understanding of design or code choices, clarification is required but action may not be necessary for approval.
❗ (Exclamation Mark) This comment is critical and requires clarification or action before approval.
Forward port of https://github.com/codice/ddf/pull/6736
What does this PR do?
Now, the WfsFilterDelegate will return null when ANDing filters and at least one is null. This means any AND group will be dropped if it contains a feature property not understood by the source being queried. If this results in no filter for the query at all, then it will not be run against the source.
Also, note that test coverage did not actually decrease with this change. The instruction coverage was updated to reflect its true value; LenientLimit has prevented this from failing the build.
Who is reviewing it?
@derekwilhelm
@alexabird
Select relevant component teams:
@codice/core-apis @codice/ogc
Ask 2 committers to review/merge the PR and tag them here.
@glenhein
@jlcsmith
How should this be tested?
Test in downstsream
Checklist:
Notes on Review Process
Please see Notes on Review Process for further guidance on requirements for merging and abbreviated reviews.
Review Comment Legend: