codice / ddf

DDF Distributed Data Framework - an open source, modular integration framework.
http://ddf.codice.org
Other
132 stars 181 forks source link

[2.26.x] Xlsx column filtering #6747

Closed kcwire closed 1 year ago

kcwire commented 1 year ago

What does this PR do?

Makes the XLSX transformer filter out empty, null, object, and binary attributes from the resulting xlsx file.

Who is reviewing it?

@glenhein @jlcsmith @jrnorth

How should this be tested?

Ingest some data, ideally of varying types. Export as xlsx via the rest endpoint: https://localhost:8993/services/catalog/query?q=8&format=xlsx

Any background context you want to provide?

This PR is to apply the same logic done for the CSV and RTF transformers.

Checklist:

Notes on Review Process

Please see Notes on Review Process for further guidance on requirements for merging and abbreviated reviews.

Review Comment Legend:

kcwire commented 1 year ago

build now

glenhein commented 1 year ago

starting hero

glenhein commented 1 year ago

In order to build with downstream projects, I had to add and embed the following to catalog-transformer-xlsx:

        <dependency>
            <groupId>org.apache.commons</groupId>
            <artifactId>commons-csv</artifactId>
            <version>${commons-csv.version}</version>
        </dependency>

After that was resolved, the XSLX output was as expected.

kcwire commented 1 year ago

build now

cxddfbot commented 1 year ago

Internal build has been started, your results will be available at build completion.

cxddfbot commented 1 year ago

Build SUCCESS See the job results in legacy Jenkins UI or in Blue Ocean UI.