2.25.x address download status info memory leak

tslockhart commented 1 year ago

What does this PR do?

Removes entries from the downloaders map inside of DownloadStatusInfoImple.java in the cleanupAfterDownload method call from ReliableResourceDownloader.

Whatever gets merged from this PR should go into release/2.15.x as well.

Who is reviewing it?

@dcruver @pklinef @middlets719 @jhunzik @figliold @mcalcote @rzwiefel @stustison @kcwire @djblue @emmberk @mojogitoverhere @rodgersh @oconnormi @coyotesqrl @cmthom10 @lessarderic

Ask 2 committers to review/merge the PR and tag them here.

@pklinef @figliold

How should this be tested?

Contact me privately for steps for testing.

Any background context you want to provide?

My project ran into a case where it was reported that the container running ddf would eventually crash due to the main process throwing an OutOfMemoryError. I was able to replicate the problem and upon inspecting the heap afterwards found that the entries downloaders map inside of DownloadStatusInfoImple.java were never being removed. This occurred in 2.15.x and 2.25.x.

Checklist:

[ ] Documentation Updated
[ ] Update / Add Threat Dragon models
[x] Update / Add Unit Tests
[ ] Update / Add Integration Tests

Review Comment Legend:

✏️ (Pencil) This comment is a nitpick or style suggestion, no action required for approval. This comment should provide a suggestion either as an in line code snippet or a gist.
❓ (Question Mark) This comment is to gain a clearer understanding of design or code choices, clarification is required but action may not be necessary for approval.
❗ (Exclamation Mark) This comment is critical and requires clarification or action before approval.