[2.26.x] Provide better transform failure message

derekwilhelm commented 11 months ago

What does this PR do?

When attempting to download a resource as part of a transform request, if the resource cannot be found or cannot be read for some reason, the transform endpoint will return a generic "Unable to transform Metacard. Try differen transformer" message. While this message may be valid in some cases, the resource transformer and any other transformer that requires the file data could provide a much better message considering this message usually ends up back to the user. In the case of a download from the UI, this is definitely true and shows within the browser window that opens. This PR checks the transformers failure cause and provides a better message for when the resource file can either not be found or not be read.

Who is reviewing it?

@jlcsmith @andrewkfiedler

Select relevant component teams:

@codice/core-apis @codice/ui

Ask 2 committers to review/merge the PR and tag them here.

@glenhein @jlcsmith

How should this be tested?

Build and deploy DDF and add DDF-UI to it
Using the UI, upload a file
Create another metacard that doesn't have a file
Go to the file system and move/delete the stored file
Either using the UI or by going to the transform endpoint, attempt to retrieve the uploaded file using the resource transformer
Verify that the response message indicates "Resource file is not available"
Using the resource transformer and going to the metacard endpoint for the non-resource file metacard, verify that the response message indicates "Resource file is not available"

Any background context you want to provide?

What are the relevant tickets?

Fixes: #____

Screenshots

Checklist:

[ ] Documentation Updated
[ ] Update / Add Threat Dragon models
[ ] Update / Add Unit Tests
[ ] Update / Add Integration Tests

Notes on Review Process

Please see Notes on Review Process for further guidance on requirements for merging and abbreviated reviews.

Review Comment Legend:

✏️ (Pencil) This comment is a nitpick or style suggestion, no action required for approval. This comment should provide a suggestion either as an in line code snippet or a gist.
❓ (Question Mark) This comment is to gain a clearer understanding of design or code choices, clarification is required but action may not be necessary for approval.
❗ (Exclamation Mark) This comment is critical and requires clarification or action before approval.

derekwilhelm commented 11 months ago

build now