search

codicocodes / dotfyle

Find the best Neovim plugins
https://dotfyle.com
MIT License
600 stars 29 forks source link

Question on updating plugin #129

Closed MisanthropicBit closed 2 months ago

MisanthropicBit commented 3 months ago

I submitted a plugin a while ago in #48 and since I've now released version 1.0.0, I'd like to add the announcement to twin. I'm not really sure how to do this after looking over the repo but I imagine I need to create an account or readd the plugin via the form link in the README?

However, I don't want to make certain private profile information public or stored on a server somewhere, and github is pretty vague on what this information entails. I've read the terms of service and privacy policy.

codicocodes commented 3 months ago

I currently do not store email addresses. I store the GitHub username, the GitHub user ID, the avatar url and a read only GitHub access token. You can see the details here: https://github.com/codicocodes/dotfyle/blob/1dc4d46b1cf55483a24a64d98114e8a0ab91e38e/prisma/schema.prisma#L13-L29

The token is used to sync configurations you've uploaded. This is the scopes requested on the token: https://github.com/codicocodes/dotfyle/blob/1dc4d46b1cf55483a24a64d98114e8a0ab91e38e/src/lib/server/auth/github/settings.ts#L7

I believe scope=read:user is readonly profile & repo information but it was a really long time since I worked on that part.

The GitHub user id is used to authenticate you as a user.

The information is made public on a page like this, https://dotfyle.com/codicocodes , together with plugins you've authored and configurations you've synced.

The form is not able to be used to add updates/announcement about plugins though, so it's not really relevant for this. The form is only usable to add new plugins.

For updates, usually the best way is to write in my discord server. You can make an issue here as well.

Either way you're not guaranteed that I notice the update but hopefully I do and remember it when i'm writing the next issue.

codicocodes commented 3 months ago

I don't scrape SUBMITTED-PLUGINS.md any longer since adding the form

MisanthropicBit commented 3 months ago

Thank you for the very detailed reply 🙂 that's all very reassuring. If it makes sense, perhaps it might be nice to add this to the docs/readme? Or at least, there's this issue to refer to.

For updates, usually the best way is to write in my discord server. You can make an issue here as well.

Thanks. I've made an issue here on the update: #131 since I don't have a discord account.

I don't scrape SUBMITTED-PLUGINS.md any longer since adding the form

Good to know, and thanks again for your continuing efforts on the site 🥳 feel free to close.