codicocodes / dotfyle

Find the best Neovim plugins
https://dotfyle.com
MIT License
657 stars 29 forks source link

Slack embeds the same for main page and repo view #57

Closed technicalpickles closed 1 year ago

technicalpickles commented 1 year ago

I shared https://dotfyle.com/ and https://dotfyle.com/ to https://dotfyle.com/technicalpickles/pickled-nvim to one of the Slacks I am in, and was surprised they render the same:

CleanShot 2023-07-29 at 12 31 54

It took a bit to find, but this is how Slack decides what to display: https://api.slack.com/reference/messaging/link-unfurling#classic_unfurl ie opengraph or twitter card metadata.

I found this which talks about how to implement opengraph: https://whitep4nth3r.com/blog/level-up-your-link-previews-in-slack/

codicocodes commented 1 year ago

Thanks for the suggestion and for the research as well! I will add this to my todo list. It would be a really nice improvement.

I am not planning on making a custom preview image for every page at the moment, as that would require generating and storing those images. But the text should easily be fixable.

codicocodes commented 1 year ago

This is now resolved thank you for making the issue. LMK if it doesn't work in slack (remember to bust the cache).

I might make some changes to the text but happy with this for now.

image

technicalpickles commented 1 year ago

Looks great! The main convention I've seen is, for user pages, to use their avatar for the image, in case that is helpful.

codicocodes commented 1 year ago

Hmm, I did not think that would work, but maybe it would. I will try it out later!

codicocodes commented 1 year ago

Thanks for the recommendation, it worked and i think is an improvement. Particularly happy with the graph for plugins with scraped images.