codidact / qpixel

Q&A-based community knowledge-sharing software
https://codidact.com
GNU Affero General Public License v3.0
385 stars 69 forks source link

"Suggested edit pending" on a post changes cursor but isn't a link #1123

Open cellio opened 1 year ago

cellio commented 1 year ago

https://meta.codidact.com/posts/288155

If there is a suggested edit pending on a post, reviewers see a notice at the top (with a button), and the "edit" link at the bottom becomes "review suggested edit" and is a link.

Users without the ability to review posts see none of this. Fine so far.

If the user who suggested the edit views the post while the edit is pending, we show the notice at the top with a link (expected). The "suggest edit" text at the bottom is replaced with "suggested edit pending". If you mouse over it, the cursor changes to imply a link. However, the text is not a link.

We should either show the text without treating it as a link, or make it a link. Reviewers see the same link at the top and bottom, so it would be consistent, and thus preferable, to do that for editors too. If that's hard, it would also be ok to not change the cursor, so it doesn't look like clicking there would do something.