search

codidact / qpixel

Q&A-based community knowledge-sharing software
https://codidact.com
GNU Affero General Public License v3.0
385 stars 69 forks source link

Counter on editing tag summaries is always 0 #1261

Closed cellio closed 9 months ago

cellio commented 9 months ago

Most editing textboxes (posts, comments, etc) now show a counter so you know when you've reached a minimum length or exceeded a max. However, the counter on tag summaries (the short description) doesn't work; it stays at 0/600 while I type. The long tag description, on the other hand, correctly shows progress toward the 30,000-character max:

screenshot

I wonder if this has something to do with the backing element type -- I notice that the summary and description also use different font faces, so the UI apparently "thinks" they're different kinds of things. I don't know if that's relevant.

Possibly related for a fix: https://github.com/codidact/qpixel/pull/1189 . The bug predates that change.

Oaphi commented 9 months ago

huh, I thought I found all use cases for the counters. Assigning to myself as I've recently tackled #1189

cellio commented 9 months ago

Thanks. Just to be clear, it was already broken when you got there. You didn't do it. But having worked on that, you might know how to fix it. :-)

Oaphi commented 9 months ago

@cellio yup, I do know how to address that — already done (and threw in a couple more improvements along the way), awaiting review.