search

codidact / qpixel

Q&A-based community knowledge-sharing software
https://codidact.com
GNU Affero General Public License v3.0
385 stars 68 forks source link

Make it directly usable in Docker #1336

Open katomaso opened 5 months ago

katomaso commented 5 months ago

Hi, I am trying to use your app semi-production in Docker and this is necessary changes to be able to run it painlessly on stock Ubuntu server with generic database.

Are any of those changes interesting for you that you would consider porting them to your code?

cellio commented 5 months ago

@Taeir I'm not directly assigning you as a reviewer (though qpixel-reviewers should cover you), but pinging you in case you have both specific knowledge here and time to review. If not, don't worry about it -- this is why we have a reviewers group. :-)

tsengia commented 3 months ago

I am very interested in this PR. Being able to deploy via Docker would be great! Let me know if I can be of help somehow.

cellio commented 3 months ago

@ArtOfCode- would you be able to help shepherd this along? I don't know if you're the right reviewer but you have a better sense of this than I do. Thanks.

@tsengia thanks for your patience. Note that our Docker setup wasn't intended for production systems and you might run into some issues. Most notably, Redis data isn't stored outside of Docker, and Redis is where we store some state info (like when you last viewed a category) and also some user preferences. Qpixel also can't send email from inside Docker. For more caveats, see https://collab.codidact.org/posts/289900/289902#answer-289902 . You said "semi-production", so maybe none of these are issues for you, but I just wanted to make sure you know.

I don't know what it would take to change any of these restrictions; if you have ideas on how to make that better, we'd welcome PRs. But this is where it stands now to the best of my limited knowledge.

cellio commented 2 months ago

@katomaso I'm sorry for the delay. This PR includes both Docker changes and other changes, but it's not clear (to me at least) how the other changes are related. Can you say more about how the Ruby and db/seeds changes are related to the Docker issue? Or are they unrelated, and we could merge the Docker changes independently of the others? Thanks.