Added flag type for changing post status (like reopen, but also lock, delete, and inverses)

codidact / qpixel

Q&A-based community knowledge-sharing software

https://codidact.com

GNU Affero General Public License v3.0

385 stars 68 forks source link

Added flag type for changing post status (like reopen, but also lock, delete, and inverses) #1355

Closed cellio closed 3 months ago

cellio commented 3 months ago

Fixes https://github.com/codidact/qpixel/issues/1354.

Added 'change post status' flag, changed 'other' to 'moderator attention' and added that it's mod-only to the description (not curators). Also changed the button on the flag modal from 'flag for moderator attention' to just 'flag for attention' because most flags are for curator attention too.

New flag reason:

change post status: This post should be reopened/closed, locked/unlocked, or deleted/undeleted. Please elaborate in the details field below.

New version of "other":

moderator attention: Please elaborate in the details field below. This flag will be seen only by moderators and administrators, not curators.

The "not curators" part in that description is intentional, as signal to people who might not realize that their other flags have a wider audience. That's something that Codidact does differently from other sites, so a little reinforcement seems helpful.

cellio commented 3 months ago

Looking good. I've added some comments with a few suggestions.

Updates:

Moved the new flag from the YAML file to be hard-coded (like "other" aka "moderator attention") already was). The YAML file is still showing up in the diff; need to figure out how to remove it from this changeset or unchange whatever it thinks changed (whitespace?).
Now that the flag reason is in the code, it enforces the requirement for details.
Generalized the confirmation message on submission since it's not just moderators.

cellio commented 3 months ago

Since the new flag reason was added to my local database, I'm now seeing the status change flag twice, but this should be fine in production where the new flag was never added to the YAML file.

Same -- I'm seeing the extra one in my dev environment because I previously seeded it and haven't figured out how to back out just that change, but it shouldn't affect prod. We can confirm that on the dev server after merge and before deploy.