search

codidact / qpixel

Q&A-based community knowledge-sharing software
https://codidact.com
GNU Affero General Public License v3.0
397 stars 68 forks source link

Tag set name change can break site behaviour #1361

Open trichoplax opened 5 months ago

trichoplax commented 5 months ago

Describe the bug A well meaning but non-technical admin can break the site by changing the name of a tag set.

To Reproduce Steps to reproduce the behavior:

  1. As an admin, go to Admin Tools on the right hand panel.
  2. Go to Global Tag sets.
  3. See red warning message about not renaming tag sets.

Expected behavior Renaming a tag set should not require technical insight. A potentially non-technical admin on a QPixel instance should not have to think about how the database works in order to make configurable changes to the interface.

Screenshots Screenshot 2024-07-05 at 13-13-41 DEV QPixel - Tag Sets

Additional context The existence of the warning message suggests that this functionality would benefit from redesign to be able to tolerate tag set name changes.

cellio commented 5 months ago

I think what's going on is that Main and Meta are baked in in places, but you could theoretically have additional tag sets that you could rename without harm. But we've never actually deployed a third tag set AFAIK and I don't know if that would turn up problems. I'd be more inclined to remove the option to rename tag sets until such time that we either redesign this to not bake in those names or see a need for additional tag sets.