codidact / qpixel

Q&A-based community knowledge-sharing software
https://codidact.com
GNU Affero General Public License v3.0
393 stars 68 forks source link

Editing a comment with a ping changes (cancels?) the ping #725

Open cellio opened 3 years ago

cellio commented 3 years ago

https://meta.codidact.com/posts/284531

  1. Add a comment to an existing thread, pinging a previous participant. User name is highlighted as normal.
  2. Edit that comment. User name is now shown in red with a "wasn't notified" tooltip.

(Still to be determined: whether the user was actually pinged.)

Here's a screenshot, from the "duplicate" comment thread on that question:

screenshot

ArtOfCode- commented 3 years ago

If you reload, is it still red?

b-Istiak-s commented 3 years ago

If you reload, is it still red?

Nope! if you haven't made any change since I tested it.

cellio commented 3 years ago

It's normal after a refresh. The concern is that if people don't refresh, they're left thinking there was a problem when there actually wasn't.