Remove empty space below data in hexedit. Change scrolling.

codilime / veles

Binary data analysis and visualization tool

https://veles.io

Apache License 2.0

1.15k stars 118 forks source link

Remove empty space below data in hexedit. Change scrolling. #379

Closed chivay closed 6 years ago

chivay commented 6 years ago

Fixes #375

mkow commented 6 years ago

I'm also not sure whether we want that longer scroll thing. I'm used to jumping to the end of file using the scrollbar, which in this version results in seeing only the last row. Any good use-case in favor of keeping this change?

mkow commented 6 years ago

Interesting: it works well now when I press Ctrl+End, but not when I press Ctrl+Shift+End (the last line is cropped by few pixels in the latter case).

mkow commented 6 years ago

Same for manually moving cursor downwards.

chivay commented 6 years ago

Everything seems to be working right now.