Disasm::toggleColumns

[malpunek]

This change is 

[chivay]

Review status: 0 of 7 files reviewed at latest revision, 7 unresolved discussions.

---

include/ui/disasm/row.h, line 41 at r2 (raw file):

  void setEntry(const EntryField* entry);
  enum ColumnName { Address, Chunks, Comments };
  void toggleColumn(ColumnName columnName);

columnName -> column_name

---

include/ui/disasm/tab.h, line 19 at r2 (raw file):

#pragma once
#include <QToolBar>

Empty line after #pragma once

---

include/ui/disasm/tab.h, line 38 at r2 (raw file):

 private:
  void createToolbars();
  QToolBar* tool_bar;

tool_bar -> tool_bar_ Maybe empty line after void createToolbar(s); ?

---

include/ui/disasm/widget.h, line 46 at r2 (raw file):

 public slots:
  void getWindow();
  void toggleColumn(Row::ColumnName columnName);

columnName -> column_name

---

src/ui/hexeditwidget.cc, line 263 at r2 (raw file):

  parser_tool_button->setToolTip(tr("Parser"));
  parser_tool_button->setAutoRaise(true);

What happened here?

---

src/ui/disasm/row.cc, line 67 at r2 (raw file):

void Row::setEntry(const EntryField* entry) {}

void Row::toggleColumn(Row::ColumnName columnName) {

columnName -> column_name

---

src/ui/disasm/tab.cc, line 19 at r2 (raw file):

#include "ui/disasm/tab.h"
#include <QToolButton>

Add empty line after #include "ui/disasm/tab.h"

---

Comments from Reviewable

[malpunek]

Review status: 0 of 6 files reviewed at latest revision, 7 unresolved discussions.

---

include/ui/disasm/row.h, line 41 at r2 (raw file):

Previously, chivay (Hubert Jasudowicz) wrote…

`columnName` -> `column_name`

Done.

---

include/ui/disasm/tab.h, line 19 at r2 (raw file):

Previously, chivay (Hubert Jasudowicz) wrote…

Empty line after `#pragma once`

Done.

---

src/ui/hexeditwidget.cc, line 263 at r2 (raw file):

Previously, chivay (Hubert Jasudowicz) wrote…

What happened here?

Done.

---

Comments from Reviewable

[malpunek]

Review status: 0 of 6 files reviewed at latest revision, 7 unresolved discussions.

---

include/ui/disasm/tab.h, line 38 at r2 (raw file):

Previously, chivay (Hubert Jasudowicz) wrote…

`tool_bar` -> `tool_bar_` Maybe empty line after `void createToolbar(s);` ?

Done.

---

include/ui/disasm/widget.h, line 46 at r2 (raw file):

Previously, chivay (Hubert Jasudowicz) wrote…

`columnName` -> `column_name`

Done.

---

src/ui/disasm/row.cc, line 67 at r2 (raw file):

Previously, chivay (Hubert Jasudowicz) wrote…

`columnName` -> `column_name`

Done.

---

src/ui/disasm/tab.cc, line 19 at r2 (raw file):

Previously, chivay (Hubert Jasudowicz) wrote…

Add empty line after `#include "ui/disasm/tab.h"`

Done.

---

Comments from Reviewable

[chivay]

Reviewed 6 of 7 files at r3. Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from Reviewable