Closed Pablito2020 closed 2 years ago
👋🏻 Hey @Pablito2020
💖 Thanks for opening this pull request 💖
This PR will be soon reviewed by a Codinasion team member and merged shortly.
I'm not familiar with rust but I tried on multiple compilers same error is there. Please check if there is an error.
Sorry, I was using cargo (the default package manager and tool for compiling packages in rust) and I used the test library that comes with it. Since in this repo only the rust file is needed (not the whole cargo project) it was not compiling.
The solution that I added on commit 6d7326c3b002dd7f16d54c13724fa61131f5fe69 is to write the tests on main instead inside a different package. Now, with rustc, compiles fine.
Thanks for the changes. Also instead of a direct approach, you have implemented test cases so I think we will have to see what @harshraj8843 has to say about this.
Hey @Pablito2020
Could you please modify the code so that it can use test cases alongside with direct approach
Means test message will only be shown on test fail
Done! Now the program only shows the message panicking when the result isn't the expected!
@harshraj8843 the README.md doesn't look good when more contributors are added, the description column gets smaller. Should we modify that?
Should we modify that?
Actually we can't
the purpose of adding contributors is to show contributors on website
Actually, I was wondering if we can add rows in contributor section instead of one single line because the description looks weird.
Actually, I was wondering if we can add rows in contributor section instead of one single line because the description looks weird.
Any solution for this @PrajwalBorkar ?
Thanks very much for contributing!
Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.
Support this project by giving it a star ⭐.
If you're looking for your next contribution, check out our help wanted issues :zap:
Actually, I was wondering if we can add rows in contributor section instead of one single line because the description looks weird.
Any solution for this @PrajwalBorkar ?
No, I don't know any. That's why I asked you.
No, I don't know any. That's why I asked you.
ok I will try ASAP 🤗
Why:
Closes #135
What's being changed:
Added an implementation of quicksort that uses generics and is easy to understand and read.
Check off the following: