search

codinasion-archive / codinasion-monorepo

Community Monorepo
https://codinasion.org
MIT License
52 stars 167 forks source link

Improvement: User can provide input values instead of hardcoding #4397

Closed brundabharadwaj closed 1 year ago

brundabharadwaj commented 1 year ago

Update https://github.com/codinasion/program/blob/master/program/swap-two-numbers/swapTwoNumbers.scala to accept user input

Improvement: User can provide input values instead of hardcoding

Expected : Values of a and b should be given as as input from the user Actual : Values of a and b are hardcoded.

File details can be found in the Closed PR.

Originally posted by @brundabharadwaj in https://github.com/codinasion/program/pull/6999#pullrequestreview-1358051570

codinasion-bot[bot] commented 1 year ago

👋🏻 Hey @brundabharadwaj

💖 Thanks for opening this issue 💖

A team member should be by to give feedback soon.

Yasir761 commented 1 year ago

@brundabharadwaj Can you please elaborate on this issue?

brundabharadwaj commented 1 year ago

@brundabharadwaj Can you please elaborate on this issue?

@Yasir761 , sure. I have updated the details. Pl' have a look.

Yasir761 commented 1 year ago

I'm not much familiar with Scala but I'll try to resolve it, and make a PR.