codinasion-archive / codinasion-programme

An open source codebase for sharing programming solutions.
https://codinasion.vercel.app/programme
MIT License
62 stars 147 forks source link

Pull #1247 must be revoked, code on pull #1247 solves Issue #1117 instead of Issue #1097, Issue #1117 must be closed and Issue #1097 must reopen #1252

Closed SpirosArk closed 2 years ago

SpirosArk commented 2 years ago

What would you like to share?

I was running up some tests for the code I submitted.

I ended up on issue #1117 and when I was about to implement it I realized that it's the same code that was merged on pull #1247 . My program that I committed on #1247 does not check whether or not the output number is divisible by any other number. The output is just odd. So the commit that fixes issue #1117 is in pull #1247 and issue #1097 should be opened again.

Additional information

No response

codinasion-bot[bot] commented 2 years ago

👋🏻 Hey @SpirosArk

💖 Thanks for opening this issue 💖

A Codinasion team member should be by to give feedback soon.

harshraj8843 commented 2 years ago

Hey @SpirosArk

the code submitted in #1247

(rand() % (upper - lower + 1)) + lower)

generate random number (even and odd both) that's why it closes the issue #1097 , I may misunderstood that but I didn't know why to reopen that issue

harshraj8843 commented 2 years ago

code on pull https://github.com/codinasion/codinasion-programme/issues/1247 solves Issue https://github.com/codinasion/codinasion-programme/issues/1117

code on pull #1247 solves Issue #1097

SpirosArk commented 2 years ago

Sorry, Pull #1250 not #1247

SpirosArk commented 2 years ago

random-prime-number.c on Pull #1250 solves issue #1117 issue #1127 must reopen

codinasion-bot[bot] commented 2 years ago

This issue has been closed !!!

📆 Total duration: 0 days