search

codinasion-archive / codinasion-programme

An open source codebase for sharing programming solutions.
https://codinasion.vercel.app/programme
MIT License
62 stars 147 forks source link

Add time and space complexity to programmes #1291

Closed harshraj8843 closed 2 years ago

harshraj8843 commented 2 years ago

I'm thinking we should add time & space complexity section in the code or in the readme file wherever possible.

Originally posted by @PrajwalBorkar in https://github.com/codinasion/codinasion-dsa/discussions/17#discussioncomment-3263518

SpirosArk commented 2 years ago

I don't know if readme is a good idea. Because different languages' implementation have different time and space complexity from language to language. If we are gonna implement this in my opinion it's better to have it as a comment in each solution

harshraj8843 commented 2 years ago

I don't think, everyone will do the same.

And also we can guarantee that it will be accurate.

So, in my opinion, we can make it optional

@PrajwalBorkar what's your suggestion ?

PrajwalBorkar commented 2 years ago

I think we can add comment in every solution.Also if we mention in issue then I think most of them will add even if they don't know they can do research which is beneficial for everyone. I think we should add this because everyone's solution will have different approaches and complexities so that the one who is referring will get a better understanding.

PrajwalBorkar commented 2 years ago

For previous codes we can create separate good first issue so folks can add time complexities.

harshraj8843 commented 2 years ago

For previous codes we can create separate good first issue so folks can add time complexities.

👍🏻

will do the same soon

I'm working on a new project 🚀 , that's why many PR(s) are not merged yet.

Sorry for the delay, will be merged soon 🤗