codinasion-archive / codinasion-programme

An open source codebase for sharing programming solutions.
https://codinasion.vercel.app/programme
MIT License
62 stars 147 forks source link

Name of class must match filename #531

Closed Anzo52 closed 2 years ago

Anzo52 commented 2 years ago

What would you like to share?

https://github.com/codinasion/codinasion-programme/blob/6fb2c99d4720f9fca06ddd57acca96059a4ad2d5/programme/years-to-days/years-to-days.java#L4

this line must be changed to:

public class years-to-days {

Additional information

I can fix and do a PR if needed.

welcome[bot] commented 2 years ago

💖 Thanks for opening this issue. 💖

A Codinasion team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

harshraj8843 commented 2 years ago

Well for now, we are ignoring that issue.

We will update all java file in a single PR soon.

We are going to have some update very soon 😄 (work on progress)

Thanks for noticing 👍🏻

Anzo52 commented 2 years ago

Actuallly, this won't be permitted in Java (the dashes, that is). It breaks stuff. 😂

harshraj8843 commented 2 years ago

Actuallly, this won't be permitted in Java (the dashes, that is). It breaks stuff. joy

You can create a PR for this, if you want 👍🏻

You can also fix other java files having this issue

harshraj8843 commented 2 years ago

We are going to have some update very soon smile (work on progress)

549

Join the discussion :-

Thanks 💖