coding-allies / projects-platform-frontend

She's Coding Projects collaboration platform for womxn in tech.
http://projects.shescoding.org/#/
MIT License
9 stars 59 forks source link

Expand contributors on project card #140

Closed jngong closed 3 years ago

jngong commented 4 years ago

Closes #93 Project card: 'expand contributors'

Discussed with Nev to use an icon instead of ellipses to signal expanded contributors

@nurmerey @partiallymisplaced Let me know if there is anything that needs to be changed. Looking forward to your feedback!

Screenshot -- When contributors are not expanded Screen Shot 2020-10-01 at 6 17 29 PM

Screenshot -- When contributors are Screen Shot 2020-10-01 at 6 17 36 PM expanded

nurmerey commented 3 years ago

@ctran14 this one addressed #93 .

nurmerey commented 3 years ago

Hi @jngong! It looks like you are very close to finishing this PR work, let us know if you need any help.

jngong commented 3 years ago

Thanks for the feedback @numerey and @partiallymisplaced! Sorry I missed this. I will try to get to addressing the comments later in the week :) Should be a quick fix!

jngong commented 3 years ago

@nurmerey and @partiallymisplaced I've made the change requested and also resolved merge conflicts with master. Thank you!