search

coding-blocks-archives / Conduit_Android_Kotlin

48 stars 22 forks source link

The app crashes when I tap on the post MyFeedFragment #2

Open ankan10 opened 3 years ago

ankan10 commented 3 years ago

Here is the link to the file. https://github.com/coding-blocks-archives/Conduit_Android_Kotlin/blob/master/app/src/main/java/io/realworld/android/ui/feed/MyFeedFragment.kt

A small issue in line:45 of the MyFeedFragment.kt file is using the global feed fragment as an action when the item is tapped else the app will crash as soon as the item is tapped in My Feed. Ideally it should be R.id.action_myFeed_openArticle

Please let me correct this even it's small and help me to begin the opensource journey with this issue. Thank You @championswimmer

Haid-Faiz commented 3 years ago

@ankan10 You can try contributing on this. I have developed it even in a better way... https://github.com/Haid-Faiz/Conduit Don't forget to star it... if you found this repo helpful.

ankan10 commented 3 years ago

@Haid-Faiz Actually I also did it and am on my way to improve more things on it :) I will check yours out.