coding-blocks / CBOnlineApp

😎⚡️Android App for Coding Blocks Online Courses
https://online.codingblocks.com
GNU General Public License v3.0
154 stars 182 forks source link

Implement Dynamic App Shortcut #179

Closed aggarwalpulkit596 closed 5 years ago

aggarwalpulkit596 commented 5 years ago

Describe the feature you'd like Implement Dynamic App Shortcut for course with maximum usage similar to like WhatsApp implementation

References https://developer.android.com/guide/topics/ui/shortcuts

rkishan516 commented 5 years ago

I would like to work on this. For this Shortcut Manager API can be used.

aggarwalpulkit596 commented 5 years ago

@rkishan516 Go Ahead

raystatic commented 5 years ago

if this is still open i would like to work on it

rkishan516 commented 5 years ago

Sorry, but I am working on this.

raystatic commented 5 years ago

okay

aggarwalpulkit596 commented 5 years ago

Obviously not if i want to implement a specific feature restricted to API>27 should i update min sdk to api 27 ? I don't thinks so

aggarwalpulkit596 commented 5 years ago

This is not how it will be implemented please read android docs

adityastic commented 5 years ago

@aggarwalpulkit596 If I am correct, are you the same guy who contributes for fossasia as well?

aggarwalpulkit596 commented 5 years ago

Yes @adityastic

adityastic commented 5 years ago

@aggarwalpulkit596 great, happy to find someone from the same community

aggarwalpulkit596 commented 5 years ago

See Implementation of MyCourse Dynamic Shortcut

rkishan516 commented 5 years ago

@aggarwalpulkit596 Actually there is nothing like dynamic Shortcut. That is just for Showing HomeActivity only. I just want alternative of HomeActivity::class.java for every course

aggarwalpulkit596 commented 5 years ago

No there is a dynamic shortcut which open my courses only if the user is logged in

aggarwalpulkit596 commented 5 years ago

Yes exactly this is the one

aggarwalpulkit596 commented 5 years ago

Similarly any other activity can be opened

aggarwalpulkit596 commented 5 years ago

You might be missing something this because this is the way to open dynamic shortcut

aggarwalpulkit596 commented 5 years ago

It is probably happening of debug apk package name works fine for signed apk

aggarwalpulkit596 commented 5 years ago

First of all this is not way it will work And Secondly you have to Open My course Activity with course having having maximum hits accessed from course run dao

aggarwalpulkit596 commented 5 years ago

It is probably happening of debug apk package name works fine for signed apk

So, what I do ?

Remove applicationId tag in build.gradle

aggarwalpulkit596 commented 5 years ago

What's the benefit of opening the course activity in the first place ? It's just a page to enroll into a course MyCourseActitvity is course consumption page

aggarwalpulkit596 commented 5 years ago

No, make a implementation similiar to of whatsapp which makes top chats dynamic shortcut automatically

aggarwalpulkit596 commented 5 years ago

Check Whatsapp Dynamic App Shortcut you'll know

aggarwalpulkit596 commented 5 years ago

See this https://images.app.goo.gl/BMHajS12oS7ipHpCA

rkishan516 commented 5 years ago

okay. Actually I am new to android thanks for giving help.

raystatic commented 5 years ago

if this is open then i would like to work on this

rkishan516 commented 5 years ago

@raystatic you may because it's taking time for me.

HardikSo commented 5 years ago

i would like to work on this.

raystatic commented 5 years ago

i would like to work on this.

I am already working on this