Custom Dialog Impl Constants cleaning

coding-blocks / CBOnlineApp

😎⚡️Android App for Coding Blocks Online Courses

https://online.codingblocks.com

GNU General Public License v3.0

153 stars 182 forks source link

Custom Dialog Impl Constants cleaning #957

Closed AsheeshSharma closed 3 years ago

AsheeshSharma commented 3 years ago

Fixes #[Add issue number here. If you do not solve the issue entirely, please change the message e.g. "First steps for issues #IssueNumber] Lots of hardcoding was used in the custom dialogs class, following has been done to clean it up

Cleaned up the hardcoded types.
Moved hardcoded strings to strings.xml

Changes: Cleaned up the custom dialog file so strings can be reused. Screenshots for the change:

boss-contributions-bot[bot] commented 3 years ago

Thanks @AsheeshSharma, for opening the pull request! 🙌

One of our mentors will review the pull request soon. ✅

Star ⭐ this project and tweet 🐦 about your contributions.

boss-contributions-bot[bot] commented 3 years ago

Congratualtions @AsheeshSharma, your pull request is merged! 🎉

Thanks for your contributions and participating in BOSS 2020. 🙌

You can claim your bounty points here. 💰