search

coding-blocks / DigitalOceanApp

Admin Console for Digital Ocean
GNU General Public License v3.0
57 stars 76 forks source link

fix failing integration tests (on travis and circleci) #106

Closed championswimmer closed 5 years ago

championswimmer commented 6 years ago

circle ci config has to be changed to Circle CI 2.0 for it to work on Circle CI

.circleci/config.yml type

https://circleci.com/docs/2.0/

aggarwalpulkit596 commented 6 years ago

okay @championswimmer

championswimmer commented 6 years ago

if both are fixed and circle ci 2.0 also works, I'll make this 3000, else this is 2000 only if only travis works

gupta1anubhav commented 6 years ago

@championswimmer can i work on this issue?

aggarwalpulkit596 commented 6 years ago

@championswimmer travis has been fixed 👍 i have claimed for 3000 points can you make that 2000 while accepting 👍

championswimmer commented 6 years ago

if circleci works too, I'll allocate 3000, or else I'll give 2000 :)

championswimmer commented 6 years ago

since most of the work was done before deadline, you can continue to finish this PR

abishekvashok commented 5 years ago

Is this fixed @championswimmer?

aggarwalpulkit596 commented 5 years ago

@abishekvashok Yup this has been fixed

aggarwalpulkit596 commented 5 years ago

@abishekvashok will close it