search

coding-blocks / DigitalOceanApp

Admin Console for Digital Ocean
GNU General Public License v3.0
56 stars 75 forks source link

Fix travis and circle ci error #108

Closed aggarwalpulkit596 closed 5 years ago

aggarwalpulkit596 commented 5 years ago

106

codecov[bot] commented 5 years ago

Codecov Report

Merging #108 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #108   +/-   ##
========================================
  Coverage      26.6%   26.6%           
  Complexity       33      33           
========================================
  Files            83      83           
  Lines          1887    1887           
  Branches         93      93           
========================================
  Hits            502     502           
  Misses         1347    1347           
  Partials         38      38

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 62dee3e...3f05262. Read the comment docs.

aggarwalpulkit596 commented 5 years ago

@championswimmer bhaiya it be merged it was pushed before 12

championswimmer commented 5 years ago

you can fix the circle ci part in this PR itself, as you had done major work before deadline. minor fixes can be added to PRs. new claims cannot be made

aggarwalpulkit596 commented 5 years ago

@championswimmer i have made the claim already i will getting the 2000 points right ?

aggarwalpulkit596 commented 5 years ago

@championswimmer bhaiya circle 2.0 doesn't support emulators so we can't have instrumentation test right now https://support.circleci.com/hc/en-us/articles/360000028928-Testing-with-Android-emulator-on-CircleCI-2-0

championswimmer commented 5 years ago

oh, lets do only unit tests on circleci then

championswimmer commented 5 years ago

@championswimmer i have made the claim already i will getting the 2000 points right ?

yes

aggarwalpulkit596 commented 5 years ago

i have updated circle to 2.0 will i be getting some extra points for that 📦 other than that 2000 points

aggarwalpulkit596 commented 5 years ago

@championswimmer i think we can't do unit test as well :P i tried running the tests locally and here what i got screenshot 2018-08-16 at 1 08 03 am

championswimmer commented 5 years ago

that's what you are supposed to fix 😮

aggarwalpulkit596 commented 5 years ago

@championswimmer it can't be done because they are instrumented test and they need a real device for that 😜 and there is only one unit test https://github.com/coding-blocks/DigitalOceanApp/blob/master/doandroidlib/src/test/java/in/tosc/doandroidlib/DigitalOceanTest.java

championswimmer commented 5 years ago

yea just run this https://github.com/coding-blocks/DigitalOceanApp/blob/master/doandroidlib/src/test/java/in/tosc/doandroidlib/DigitalOceanTest.java on circleci

I thought you got an error on this test.

championswimmer commented 5 years ago

as in just run test not connectedCheck on circleci

aggarwalpulkit596 commented 5 years ago

Okay this can be done :+1: