search

coding-blocks / DigitalOceanApp

Admin Console for Digital Ocean
GNU General Public License v3.0
56 stars 75 forks source link

Revamped DropletCreateActivity UX/UI #114

Closed jddeep closed 5 years ago

jddeep commented 5 years ago

Fixes #111 Revamped DropletCreateActivity UX/UI.

jddeep commented 5 years ago

@championswimmer @aggarwalpulkit596 Done 👍 Please merge. Thanks.

aggarwalpulkit596 commented 5 years ago

Do they look good to you? Please use some decent design, card corner aren't even visible and text inside the cards look extremely bad

jddeep commented 5 years ago

Do they look good to you? Please use some decent design, card corner aren't even visible and text inside the cards look extremely bad

@aggarwalpulkit596 Can you be more specific with the design Like I added the rounded corners, improved text format, etc.. What more can be improved? Do you want a larger rounded radius?

jddeep commented 5 years ago

@aggarwalpulkit596 Have a look now at the image

aggarwalpulkit596 commented 5 years ago

Text size is extremely big improper padding/margin etc i shouldn't be telling you these basic building blocks of UX check other apps/websites for reference obviously for adding a card making rounded corners i can't give you any points for this and revamping layouts means some improvisation which is actually appreciable don't do stuff just to get points try to actually do something meaningful otherwise there's no point participating in this or any other competition

jddeep commented 5 years ago

@aggarwalpulkit596 Thanks. Just was checking with my expectations. Will do the text formatting. The content in a single card is so much that you can't really revamp a whole lot. Still i have made a lot of formats. I felt the text size is cool as it will get the attention of the user also keeping in mind accessibility. Hope you understand. But anyways will reduce size and all now.

jddeep commented 5 years ago

@aggarwalpulkit596 Have a look now please at the image.

jddeep commented 5 years ago

@aggarwalpulkit596 I have made your requested changes. Can you please update me or tell me if something more or else needs to be changed. Thanks.

aggarwalpulkit596 commented 5 years ago

Travis is failing

jddeep commented 5 years ago

Travis is failing

@aggarwalpulkit596 It is trying to launch an emulator. And there is some problem regarding that.

aggarwalpulkit596 commented 5 years ago

Read the error and try to fix that

jddeep commented 5 years ago

@aggarwalpulkit596 It is showing Emulator is out of date . But my SDK tools are updated locally.

jddeep commented 5 years ago

@aggarwalpulkit596 Even in the previous PR we merged, we had this Emulator outdate problem.

aggarwalpulkit596 commented 5 years ago

So create a seperate issue and fix this first

jddeep commented 5 years ago

@aggarwalpulkit596 Please merge this as builds have been resolved. Also please increase the bounties on this.

jddeep commented 5 years ago

@aggarwalpulkit596 @championswimmer Can we please get this merged? Changes requested were made. Also please update the bounty on the issue for this as aforesaid. Thank you.