search

coding-blocks / DigitalOceanApp

Admin Console for Digital Ocean
GNU General Public License v3.0
56 stars 75 forks source link

Travis fix for emulator build failures #116

Closed jddeep closed 5 years ago

jddeep commented 5 years ago

Fixes #115 Travis fix for emulator build failures.

jddeep commented 5 years ago

@championswimmer @aggarwalpulkit596 Currently the error is : Unable to detect adb version, adb output: /usr/local/android-sdk/platform-tools/adb: /lib/x86_64-linux-gnu/libc.so.6: versionGLIBC_2.16' not found (required by /usr/local/android-sdk/platform-tools/adb)` . I have tried many changes in the .yml file, changes locally but this particular error log seems not to get fixed. Any ideas?

jddeep commented 5 years ago

@championswimmer @aggarwalpulkit596 Currently the error is : Unable to detect adb version, adb output: /usr/local/android-sdk/platform-tools/adb: /lib/x86_64-linux-gnu/libc.so.6: versionGLIBC_2.16' not found (required by /usr/local/android-sdk/platform-tools/adb)` . I have tried many changes in the .yml file, changes locally but this particular error log seems not to get fixed. Any ideas?

@aggarwalpulkit596 I HAVE FIXED THE EMULATOR ERROR but I have been working for days trying to resolve this error. The builds run fine and have been successful here locally.

jddeep commented 5 years ago

@aggarwalpulkit596 The jacocoTestReport gives errors like No view with id xyz was found in the view hierarchy but I looked through the layouts and it's bindings, everything was fine and even the layouts got created in the app perfectly. Why do you think this is happening?

aggarwalpulkit596 commented 5 years ago

You have changed the layouts so you have to the change it in instrumentation test as well

jddeep commented 5 years ago

@aggarwalpulkit596 First of all the layout which I changed, was in a different branch. Here in this branch everything is same. Moreover, the test failures are of different layouts.

jddeep commented 5 years ago

@aggarwalpulkit596 I have checked the layouts thoroughly, they are completely fine with correct ids. We can do one thing. I have fixed the emulator test fails and ./gradlew build fails. You can merge this and see the latter error yourself once.

jddeep commented 5 years ago

@championswimmer @aggarwalpulkit596 There were also some errors of validatesigning. I took care of those as well, as you can see from the files changed. Thanks.

aggarwalpulkit596 commented 5 years ago

The exception which Travis is showing is that com.android.builder.testing.api.DeviceException: Could not create ADB Bridge. ADB location: /usr/local/android-sdk/platform-tools/adb you need to fix that first

jddeep commented 5 years ago

The exception which Travis is showing is that com.android.builder.testing.api.DeviceException: Could not create ADB Bridge. ADB location: /usr/local/android-sdk/platform-tools/adb you need to fix that first

There is no such issue for adb when I run the jacocoTestReport locally. I think the project's travis needs to be changed completely, need to remove lot of things. Cause otherwise this adb issue persists over here, have tried every possible solution I could find.

aggarwalpulkit596 commented 5 years ago

JacocoTestReport is an different thing and not at all connected to Travis read about Travis on their website

jddeep commented 5 years ago

JacocoTestReport is an different thing and not at all connected to Travis read about Travis on their website

But in the Travis build log here, the command for which the test is failing is jacocoTestReport.

jddeep commented 5 years ago

So naturally i need to test that command locally. But that command does not gives any adb error locally. Instead gives some missing layout ids stuff which i haven't changed anything.

jddeep commented 5 years ago

@aggarwalpulkit596 Did you get what i am saying?

aggarwalpulkit596 commented 5 years ago

The point is that there is nothing wrong JacocoTestReport but the tools and emulator which Travis build for generating report are obsolete and needs to be updated

jddeep commented 5 years ago

The point is that there is nothing wrong JacocoTestReport but the tools and emulator which Travis build for generating report are obsolete and needs to be updated

I am trying different ways and will keep on trying. One thing, so do I need to simply update the $BUILD_TOOLS?

jddeep commented 5 years ago

@aggarwalpulkit596 @championswimmer Have fixed the error mentioned for Issue #116 . Now it is upto you guys (admins) to care of this : Execution failed for task ':app:validateSigningRelease'. Keystore file not set for signing config release

jddeep commented 5 years ago

@aggarwalpulkit596 Please merge this ASAP so that I can proceed with further issues.

jddeep commented 5 years ago

@aggarwalpulkit596 I have claimed the bounty for this and some others. Please accept them. Thanks.