search

coding-blocks / DigitalOceanApp

Admin Console for Digital Ocean
GNU General Public License v3.0
56 stars 75 forks source link

Issues in additional options in DetailDropletActivity #43

Closed ojasvajain closed 7 years ago

ojasvajain commented 7 years ago

I came across these issues in DetailDropletActivity. Here I am referring to 'Enable Backup, Enable IPv6 and Private Network' as options:

Issue - The snackbar doesn't always show up when an option is enabled/disabled. ezgif-1-842ca69c29 Here I enabled Backup option, but there was no snackbar.

Issue - If an option is enabled/disabled from DetailDropletActivity, if we open DetailDropletActivity again, the switch corresponding to that option remains off, always. ezgif-1-78e1973830 Initially backup option was enabled, I go back to DropletActivity and again open DetailDropletActivity. As you can see, the option is switched off.

Issue - Since private networking and IPv6 can not be disabled once they are enabled, the app should restrict the user from switching off those options if they are enabled and show appropriate message in snackbar.

Currently this is the scenario ezgif-1-8d7d7af239 Switch can be changed to off state.

How it should behave ezgif-xc. Switch can't be changed to off state, once it is switched on.

Are you willing to work on these issues: Yes

ojasvajain commented 7 years ago

Please review my PR.