search

coding-blocks / DigitalOceanApp

Admin Console for Digital Ocean
GNU General Public License v3.0
56 stars 75 forks source link

The Settings button on the home screen isn't functioning. #68

Open vinayakkgarg opened 6 years ago

vinayakkgarg commented 6 years ago

screenshot_20180515-201446

4lch4 commented 6 years ago

I was able to reproduce this on my device and will see if I can't fix it and submit a PR. I've never worked on this project before but I'd like to help.

4lch4 commented 6 years ago

I've figured out the cause of the bug, there's no SettingsActivity or Fragment 😅

I'll submit a PR to remove the Settings button until the Activity has been created.

4lch4 commented 6 years ago

I see it's not going to actually be that easy... I've removed the Settings option but it screws with how they have the Toolbar formatted.

Gonna take me a bit more time to fix it seems.

4lch4 commented 6 years ago

There we go @vinayakkgarg, I've submitted a PR which fixes the issue. Here's to hoping the maintainers can add it soon. 😄

4lch4 commented 6 years ago

Hey @championswimmer, this issue can be closed. I'd close it myself but I don't have permissions too.