search

coding-blocks / DigitalOceanApp

Admin Console for Digital Ocean
GNU General Public License v3.0
56 stars 76 forks source link

Add databinding to activities #71

Open AkshayCHD opened 6 years ago

AkshayCHD commented 6 years ago

Used databinding in the activites java files to reduce the boilerplate code. fixes #72

championswimmer commented 6 years ago

Please fix the codacy issues and make sure the tests do not fail

championswimmer commented 6 years ago

Check the error (UI tests) here https://travis-ci.org/coding-blocks/DigitalOceanApp/jobs/380232125

codecov[bot] commented 6 years ago

Codecov Report

Merging #71 into master will decrease coverage by 0.05%. The diff coverage is 15%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #71      +/-   ##
============================================
- Coverage     27.39%   27.34%   -0.06%     
  Complexity       33       33              
============================================
  Files            83       83              
  Lines          1865     1854      -11     
  Branches         91       91              
============================================
- Hits            511      507       -4     
+ Misses         1319     1312       -7     
  Partials         35       35
Impacted Files Coverage Δ Complexity Δ
...italoceanapp/activities/DetailDropletActivity.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
...osc/digitaloceanapp/activities/SplashActivity.java 20% <100%> (-1.57%) 0 <0> (ø)
...italoceanapp/activities/DropletCreateActivity.java 38.8% <28.57%> (-2.63%) 0 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4a793a3...6f710d8. Read the comment docs.

AkshayCHD commented 6 years ago

@championswimmer the codeclimate test renders ambiguous results, rest all tests have passed, please have a look

4lch4 commented 6 years ago

@AkshayCHD could you not move the lines that codeclimate are complaining about to their own method?

It seems to just be complaining that some code is similar (lines 207/235), which could be moved to a single method with parameters and that should fix it.

EDIT: I haven't actually looked at the code in its entirety so I'm not sure how feasible this is, hence my asking. Forgot to mention this part.

AkshayCHD commented 6 years ago

@Alcha actually the problem is that the codes represent two cases of a switch case and although the codes look similar there are alot of case specific variables in each case. So if i create a common function i would have an overhead of checking again and again which case is it, which is not desired in my opinion. I could be wrong about it, I don't know for sure, but thank you for the suggestion.

4lch4 commented 6 years ago

Ahhh, that makes sense then. No worries 😊