coding-blocks / DigitalOceanApp

Admin Console for Digital Ocean
GNU General Public License v3.0
56 stars 75 forks source link

Update of dependencies and build tools #73

Closed 4lch4 closed 6 years ago

4lch4 commented 6 years ago

PR Request to update dependencies and build tools

What's it do?

Updates the Gradle build tools, Google GSON library, adds the Google Maven repository to all modules, and updates all compile/testCompile references to their non-deprecated versions.

What was wrong?

The versions were simply out of date and needed updating and verification that no problems occurred as a result.

How's it fixed?

  1. All the versions were updated at first, however, they needed the Google repository.

  2. I added the Google Maven repository in the build files so they could be located.

  3. The build files still used compile and testCompile which was throwing warnings about the plan to stop supporting them by the end of 2018 so I updated their references:

    • In the app build.gradle file, they needed to be changed to implementation and testImplementation respectively.
    • In the library's build.gradle file, they needed to be changed to api and testImplementation respectively.
4lch4 commented 6 years ago

Awww, looks like the Travis build has failed. Looking into that now..

4lch4 commented 6 years ago

Hmm... Not too sure what the issue is with the latest build.. I'll see what I can figure out.

4lch4 commented 6 years ago

I'm honestly at a loss for what to do to fix the Travis build. Anyone have a suggestion?

Build log:

* What went wrong:
Could not determine the dependencies of task ':app:testDebugUnitTest'.
> Task with path 'unzipJacocoAgent' not found in project ':app'.
championswimmer commented 6 years ago

@Alcha You'll have to follow this to setup unified coverage https://proandroiddev.com/unified-code-coverage-for-android-revisited-44789c9b722f

You need to remove jacoco-everywhere plugin. It is deprecated

4lch4 commented 6 years ago

Thanks, @championswimmer, I'll be sure to get that fixed and submit a new commit soon.

4lch4 commented 6 years ago

Alrighty, I have some time now so I'm gonna get this fixed.

codecov[bot] commented 6 years ago

Codecov Report

Merging #73 into master will decrease coverage by 6.82%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #73      +/-   ##
===========================================
- Coverage     12.67%   5.85%   -6.83%     
+ Complexity       47      16      -31     
===========================================
  Files            82      82              
  Lines          1862    1862              
  Branches         91      91              
===========================================
- Hits            236     109     -127     
- Misses         1614    1744     +130     
+ Partials         12       9       -3
Impacted Files Coverage Δ Complexity Δ
...va/in/tosc/doandroidlib/mockapi/MockResponses.java 0% <0%> (-87.5%) 0% <0%> (-1%)
...n/java/in/tosc/doandroidlib/common/ActionType.java 0% <0%> (-82.5%) 0% <0%> (-2%)
...n/java/in/tosc/doandroidlib/mockapi/MockUtils.java 0% <0%> (-76%) 0% <0%> (ø)
...c/main/java/in/tosc/doandroidlib/DigitalOcean.java 0% <0%> (-63.47%) 0% <0%> (-6%)
...ava/in/tosc/doandroidlib/common/DropletStatus.java 0% <0%> (-53.34%) 0% <0%> (-2%)
...in/java/in/tosc/doandroidlib/common/ImageType.java 0% <0%> (-50%) 0% <0%> (-2%)
...java/in/tosc/doandroidlib/objects/AccountInfo.java 0% <0%> (-40%) 0% <0%> (-2%)
...in/java/in/tosc/doandroidlib/objects/Droplets.java 0% <0%> (-40%) 0% <0%> (-2%)
...c/main/java/in/tosc/doandroidlib/objects/Meta.java 0% <0%> (-20%) 0% <0%> (-1%)
...va/in/tosc/doandroidlib/objects/RateLimitBase.java 0% <0%> (-20%) 0% <0%> (-1%)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3c70b16...2ca143c. Read the comment docs.

4lch4 commented 6 years ago

_schweeeeeeet, it's fixed!

Dancing

@championswimmer if you'd like to merge the PR it shouldn't cause any more problems as I updated to the new Jacoco plugin per the guide you linked. Thank you for that.