coding-blocks / DigitalOceanApp

Admin Console for Digital Ocean
GNU General Public License v3.0
56 stars 75 forks source link

Add databinding to fragments (#74) #75

Open AkshayCHD opened 6 years ago

AkshayCHD commented 6 years ago

fixes #74

codecov[bot] commented 6 years ago

Codecov Report

Merging #75 into master will increase coverage by 0.03%. The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #75      +/-   ##
===========================================
+ Coverage     12.67%   12.7%   +0.03%     
  Complexity       47      47              
===========================================
  Files            82      82              
  Lines          1862    1857       -5     
  Branches         91      91              
===========================================
  Hits            236     236              
+ Misses         1614    1609       -5     
  Partials         12      12
Impacted Files Coverage Δ Complexity Δ
...digitaloceanapp/fragments/SelectImageFragment.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
.../digitaloceanapp/fragments/DataCenterFragment.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
.../digitaloceanapp/fragments/SelectSizeFragment.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
...loceanapp/fragments/AdditionalDetailsFragment.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3c70b16...f19c02e. Read the comment docs.

AkshayCHD commented 6 years ago

@championswimmer @the-dagger please have a look. About the code climate tests they are really inconsistent, the first kind of error regarding similar code are not correct, the codes are very different, and that to from the code that i didn't even change. The other errors are regarding the order of import statements which i changed thrice but each time it gives an error and tells a new order.