search

coding-blocks / DigitalOceanApp

Admin Console for Digital Ocean
GNU General Public License v3.0
56 stars 76 forks source link

Remove useless content (#76) #77

Closed AkshayCHD closed 6 years ago

AkshayCHD commented 6 years ago

fixes #76

codecov[bot] commented 6 years ago

Codecov Report

Merging #77 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #77   +/-   ##
=========================================
  Coverage     12.67%   12.67%           
  Complexity       47       47           
=========================================
  Files            82       82           
  Lines          1862     1862           
  Branches         91       91           
=========================================
  Hits            236      236           
  Misses         1614     1614           
  Partials         12       12
Impacted Files Coverage Δ Complexity Δ
...tosc/digitaloceanapp/adapters/DropletsAdapter.java 72.72% <ø> (ø) 4 <0> (ø) :arrow_down:
...tosc/digitaloceanapp/activities/AboutActivity.java 31.57% <ø> (ø) 2 <0> (ø) :arrow_down:
.../digitaloceanapp/fragments/DataCenterFragment.java 0% <ø> (ø) 0 <0> (ø) :arrow_down:
...loceanapp/fragments/AdditionalDetailsFragment.java 0% <ø> (ø) 0 <0> (ø) :arrow_down:
.../digitaloceanapp/fragments/SelectSizeFragment.java 0% <ø> (ø) 0 <0> (ø) :arrow_down:
...a/in/tosc/digitaloceanapp/utils/FontsOverride.java 72.97% <ø> (ø) 3 <0> (ø) :arrow_down:
...italoceanapp/activities/DetailDropletActivity.java 0% <ø> (ø) 0 <0> (ø) :arrow_down:
...italoceanapp/activities/DropletCreateActivity.java 0% <ø> (ø) 0 <0> (ø) :arrow_down:
...sc/digitaloceanapp/activities/DropletActivity.java 40.86% <ø> (ø) 5 <0> (ø) :arrow_down:
...sc/digitaloceanapp/adapters/SelectSizeAdapter.java 0% <ø> (ø) 0 <0> (ø) :arrow_down:
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3c70b16...4439440. Read the comment docs.

4lch4 commented 6 years ago

Out of curiosity, will these PR's work fine with the latest build tools as I updated in my PR #73? Granted, I still have to figure out what's wrong with Travis but after that's worked out, will it cause any issues with the PR's you've been submitting, @AkshayCHD?

AkshayCHD commented 6 years ago

@the-dagger @championswimmer please have a look

championswimmer commented 6 years ago

Please make some constructive contributions from the future. Not just for the sake of raking some BOSS bounties or green streaks on Github. This is the most pointless PR I have seen till now. Especially with all the authorship removal.

AkshayCHD commented 6 years ago

@championswimmer sorry you felt that way, i had no such intentions, there were some unused import statements and variables that were there in the code so i thought that they need to be removed, and about the authorship comments, I contributed in a project at FOSSASIA, there whever i made a pr the maintainer asked me to remove authorship comments very first so i thought same would apply here. But are't the unused statements and variables supposed to be removed.