coding-blocks / DigitalOceanApp

Admin Console for Digital Ocean
GNU General Public License v3.0
56 stars 75 forks source link

Add DataBinding to Activities #86

Closed aggarwalpulkit596 closed 6 years ago

aggarwalpulkit596 commented 6 years ago

Issues #72

codecov[bot] commented 6 years ago

Codecov Report

Merging #86 into master will decrease coverage by 0.85%. The diff coverage is 15.87%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #86      +/-   ##
============================================
- Coverage     27.39%   26.54%   -0.86%     
  Complexity       33       33              
============================================
  Files            83       83              
  Lines          1865     1880      +15     
  Branches         91       90       -1     
============================================
- Hits            511      499      -12     
- Misses         1319     1345      +26     
- Partials         35       36       +1
Impacted Files Coverage Δ Complexity Δ
...tosc/digitaloceanapp/activities/AboutActivity.java 86.66% <ø> (ø) 0 <0> (ø) :arrow_down:
...loceanapp/fragments/AdditionalDetailsFragment.java 42.85% <0%> (-3.7%) 0 <0> (ø)
...italoceanapp/activities/DetailDropletActivity.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
...italoceanapp/activities/DropletCreateActivity.java 38.8% <14.28%> (-2.63%) 0 <0> (ø)
...osc/digitaloceanapp/activities/SplashActivity.java 16.66% <75%> (-4.91%) 0 <0> (ø)
...sc/digitaloceanapp/activities/DropletActivity.java 64.22% <76.19%> (-1.87%) 0 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4a793a3...a35144e. Read the comment docs.

aggarwalpulkit596 commented 6 years ago

@championswimmer PR is ready to be merged i guess ?

aggarwalpulkit596 commented 6 years ago

@championswimmer bhaiya my previous commit passed on Travis ci but was a codacy error to make variable Private and now after making them Private the test are failing will you look into that issue

aggarwalpulkit596 commented 6 years ago

@championswimmer kindly review this pr and merge this one too.

aggarwalpulkit596 commented 6 years ago

@championswimmer kindly see this pr also and review this one also so i can work further on issues