search

coding-blocks / DigitalOceanApp

Admin Console for Digital Ocean
GNU General Public License v3.0
56 stars 75 forks source link

Refactored AboutActivity and layout file #87

Closed 4lch4 closed 6 years ago

4lch4 commented 6 years ago

The activity now sends people to the correct Contributors page instead of ones limited to a specific period of time.

The layout is also much simpler now and no longer contains unnecessary elements, such as the previous LinearLayout that wrapped the ScrollLayout and was completely useless.

This PR is quite a small one so I didn't include too much information. If you want me to explain some more I'd be glad to, just let me know.

4lch4 commented 6 years ago

Forgot to mention I also added some default dimensions for various things such as margins, card view elevation, etc., that I'll be using later on with more refactors.

In regards to the CodeClimate/Codacy issue, there's no need for a default statement as there are only ever two instances when that function is called and it's when a user is pressing on one of the views.

championswimmer commented 6 years ago

Travis is still failing

4lch4 commented 6 years ago

Alright, sorry for the delay, I had a few other things come up that took my time. I'll take a look at this now and see if I can't get it fixed tonight.

4lch4 commented 6 years ago

I've been unable to figure out why it's crashing on Travis... That said, there have already been some changes so I'll close this PR and submit changes at a later date.