coding-blocks / DigitalOceanApp

Admin Console for Digital Ocean
GNU General Public License v3.0
56 stars 75 forks source link

fix crash in DropletActivity #93

Closed championswimmer closed 5 years ago

championswimmer commented 6 years ago

Logs

java.lang.NullPointerException: 

  at in.tosc.digitaloceanapp.activities.DropletActivity$4.onResponse (DropletActivity.java)

  at retrofit2.ExecutorCallAdapterFactory$ExecutorCallbackCall$1$1.run (ExecutorCallAdapterFactory.java)

  at android.os.Handler.handleCallback (Handler.java:751)

  at android.os.Handler.dispatchMessage (Handler.java:95)

  at android.os.Looper.loop (Looper.java:154)

  at android.app.ActivityThread.main (ActivityThread.java:6688)

  at java.lang.reflect.Method.invoke (Method.java)

  at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run (ZygoteInit.java:1468)

  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1358)
championswimmer commented 6 years ago

Second log

java.lang.NullPointerException: 

  at in.tosc.digitaloceanapp.activities.DropletActivity$3.onResponse (DropletActivity.java)

  at retrofit2.ExecutorCallAdapterFactory$ExecutorCallbackCall$1$1.run (ExecutorCallAdapterFactory.java)

  at android.os.Handler.handleCallback (Handler.java:751)

  at android.os.Handler.dispatchMessage (Handler.java:95)

  at android.os.Looper.loop (Looper.java:154)

  at android.app.ActivityThread.main (ActivityThread.java:6688)

  at java.lang.reflect.Method.invoke (Method.java)

  at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run (ZygoteInit.java:1468)

  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1358)
championswimmer commented 6 years ago

These are two different errors, both due to most probably request finishing after user navigating away.

Both need to be fixed

aggarwalpulkit596 commented 6 years ago

On it

aggarwalpulkit596 commented 6 years ago

@championswimmer bhaiya I'm not able to replicate the error can you the steps to replicate the errors

venomousboxer commented 6 years ago

@championswimmer please review #95 pr as well

aggarwalpulkit596 commented 6 years ago

screen shot 2018-06-09 at 2 09 00 pm Some issue running travis test @championswimmer please check

aggarwalpulkit596 commented 6 years ago

https://github.com/coding-blocks/DigitalOceanApp/issues/96 Travis has to be fixed first

venomousboxer commented 6 years ago

@championswimmer Travis errors solved in pr #95