coding-blocks / DigitalOceanApp

Admin Console for Digital Ocean
GNU General Public License v3.0
56 stars 75 forks source link

Fixes for Droplet Activity #94

Closed aggarwalpulkit596 closed 6 years ago

aggarwalpulkit596 commented 6 years ago

Fix #93 Annotated Response with @Nonull and checking whether the response is successful or not and response body is not null

codecov[bot] commented 6 years ago

Codecov Report

Merging #94 into master will decrease coverage by 0.67%. The diff coverage is 55.55%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #94      +/-   ##
============================================
- Coverage     27.51%   26.83%   -0.68%     
  Complexity       33       33              
============================================
  Files            83       83              
  Lines          1872     1867       -5     
  Branches         94       93       -1     
============================================
- Hits            515      501      -14     
- Misses         1320     1328       +8     
- Partials         37       38       +1
Impacted Files Coverage Δ Complexity Δ
...sc/digitaloceanapp/activities/DropletActivity.java 56.41% <55.55%> (-9.17%) 0 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b1b1036...d363b55. Read the comment docs.

aggarwalpulkit596 commented 6 years ago

@the-dagger kindly check travis and fix is #97

aggarwalpulkit596 commented 6 years ago

@championswimmer kindly review