search

coding-blocks / DigitalOceanApp

Admin Console for Digital Ocean
GNU General Public License v3.0
56 stars 75 forks source link

fixing crash in DropletActivity #95

Closed venomousboxer closed 6 years ago

venomousboxer commented 6 years ago

Fixes : #93

Changes : Added if statements for checking if the response was successful and added NotNull annotation to response and call parameters of onResponse function.

venomousboxer commented 6 years ago

@championswimmer travis is failing because of some failed tests. Please look at it

codecov[bot] commented 6 years ago

Codecov Report

Merging #95 into master will increase coverage by 0.11%. The diff coverage is 56.52%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #95      +/-   ##
============================================
+ Coverage     27.39%   27.51%   +0.11%     
  Complexity       33       33              
============================================
  Files            83       83              
  Lines          1865     1872       +7     
  Branches         91       94       +3     
============================================
+ Hits            511      515       +4     
- Misses         1319     1320       +1     
- Partials         35       37       +2
Impacted Files Coverage Δ Complexity Δ
...sc/digitaloceanapp/activities/DropletActivity.java 65.57% <56.52%> (-0.52%) 0 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5602d7b...d925a0f. Read the comment docs.

venomousboxer commented 6 years ago

@championswimmer @Alcha can you please review the pull now

4lch4 commented 6 years ago

Sorry for being so late to this issue, looks like Arnav took care of it.