search

coding-blocks / content-downloader

Python package to download files on any topic in bulk.
MIT License
8 stars 25 forks source link

fix package not found issue #4

Closed abhishek97 closed 7 years ago

abhishek97 commented 7 years ago

Fix : https://github.com/coding-blocks/content-downloader/issues/3

championswimmer commented 7 years ago

@nikhilkumarsingh is this a py2 vs py3 thing ?

abhishek97 commented 7 years ago

@championswimmer I believe this is has something to do with the version of requests package. here : https://stackoverflow.com/questions/28904607/cannot-import-requests-packages-urllib3-util-retry

nikhilkumarsingh commented 7 years ago

I dont think this qualifies as a fix. User must use latest version of requests package.

abhishek97 commented 7 years ago

@nikhilkumarsingh yes, so in the recent version we need to 

from urllib3.util import Retry

instead of from requests.packages.urllib3.util.retry import Retry right?

nikhilkumarsingh commented 7 years ago

No. from requests.packages.urllib3.util.retry import Retry is working in latest version. Are you using latest version of requests?

abhishek97 commented 7 years ago

@championswimmer @nikhilkumarsingh It is so that the version i get from pip install -r ctdl is 2.16.0 (default you'll get on mac ) , changed requirements.txt to specify a version to use. This should fix this. It is fine on 2.5.1