search

coding-blocks / content-downloader

Python package to download files on any topic in bulk.
MIT License
8 stars 25 forks source link

gui support for website specific search #8

Closed akansh97531 closed 7 years ago

akansh97531 commented 7 years ago

@nikhilkumarsingh

akansh97531 commented 7 years ago

also fixed some bugs in gui

nikhilkumarsingh commented 7 years ago

@akansh97531 Please wait for #7 to get merged. Then you can add support for same in GUI.

You will have to PULL the changes once #7 is merged. Then you carry on with GUI modifications.

akansh97531 commented 7 years ago

@nikhilkumarsingh i added duckduckgo as an option please review

nikhilkumarsingh commented 7 years ago

Please use same function implementations for google and duckduckgo. Try to avoid extra no. of lines.

akansh97531 commented 7 years ago

there will be some differences in both implementations like for query parameter

nikhilkumarsingh commented 7 years ago

At least use consistent function names @akansh97531

akansh97531 commented 7 years ago

renamed function names