search

coding-blocks / judge-api

7 stars 27 forks source link

Added tslint and prettierrc #76

Open prathambatra opened 4 years ago

prathambatra commented 4 years ago

Signed-off-by: prathambatra batrapratham999@gmail.com fixes #72

prathambatra commented 4 years ago

@jatinkatyal13 I have setup this. but on running npm lint I got lot of errors. I don't know much about prettier and linting.

prabalsingh24 commented 4 years ago

Are you getting errors for 'test' directory? because I have used semi colon and tabWidth = 4 in my PRs :sweat_smile: ( I realized it later :( )

jatinkatyal13 commented 4 years ago

That's what linting is for, yes it will have a lot of errors because the code wasn't written in a consistent manner. We should aim to have no linting errors ideally but code would function nonetheless

prathambatra commented 4 years ago

what should i do now? all configs are fine?

jatinkatyal13 commented 4 years ago

LGTM!

prathambatra commented 4 years ago

travis CI build is failing

prabalsingh24 commented 4 years ago

travis CI build is failing

@jatinkatyal13 travis-ci is running this command docker exec judgecompose_api_1 scripts/wait-for-it.sh -t 180 api:3737 -- npm run seedlangs which is creating an API key before the tests begin. And because the same api key value is used here beforeEach. it is throwing an error :)

prathambatra commented 4 years ago

@jatinkatyal13

jatinkatyal13 commented 4 years ago

back merge with the current Head and the test should not fail