coding-blocks / trouble-maker-frontend

1 stars 22 forks source link

Add Delete Question Button #1

Closed abhishek97 closed 6 years ago

abhishek97 commented 6 years ago
  1. Use a native confirm dialogue to confirm before deletion
  2. Button should be visible at /questions
vibhorgupta-gh commented 6 years ago

There's no way to test this, the callback from oneauth doesn't redirect anywhere. There seems to be no sample instance of users/questions to test this feature out. A little help @abhishek97

firefinchdev commented 6 years ago

@abhishek97 Done #4

abhishek97 commented 6 years ago

@VibhorCodecianGupta The project should just work out of the box.

the callback from oneauth doesn't redirect anywhere

Why? it should redirect back to locahost:4200/callback, do you see any errors?

There seems to be no sample instance of users/questions to test this feature out.

There are already some questions if your run seeds. However, if that is not enough, you can always add some in the database directly.

The Migrations seem to be broken a bit, meanwhile, I fix them, just don't run migrations and run the project with empty db, the schema will be generated due to sequelize.sync() call. Let me know if you still can't run it.

vibhorgupta-gh commented 6 years ago

@abhishek97 sorry I wasn't descriptive enough.

Why? it should redirect back to localhost:4200/callback, do you see any errors?

No errors related to this, it does redirect there. The URL is localhost:4200/callback?code=<code>. It doesn't go any further. Though I'm guessing that's expected behavior.

There are already some questions if your run seeds. However, if that is not enough, you can always add some in the database directly.

Are you talking about the database created by setting up trouble-maker backend? In that case, just a dummy user is created, no questions. The landing page just contains the nav bar and nothing else. No questions. Btw, I already ran all the seeds and migrations.

Added a question or two in the database, no luck.

Running just the seeds yields this error (as per the updated README in trouble-maker) -

screen shot 2018-07-20 at 2 23 19 pm

Let me know if you still can't run it.

I was able to run it before as well, but only the nav bar renders and nothing else. Login expectedly doesn't take me anywhere

abhishek97 commented 6 years ago

@VibhorCodecianGupta I've updated the README.md for trouble-maker-backend. You should NOT be running migrations and schema is created by calling .sync(), just run the app on a blank db.

As for the login issue, make sure you have the backend running, check that you receive a request at the backend with the code you see in the URL. It is working for me and others working on the project so there should not be anything special for you to do.

vibhorgupta-gh commented 6 years ago

@abhishek97 Figured it out, thanks a lot :D

One issue though, after logging in, when I click on the questions tab it logs me out of the session. I can see the request logging in the console, it calls api/logout This is after I added a question in the database myself