search

coding-blocks / trouble-maker-frontend

1 stars 22 forks source link

Add Searchbox for /questions #2

Closed abhishek97 closed 6 years ago

abhishek97 commented 6 years ago

The backend (https://github.com/coding-blocks/trouble-maker) response is paginated by default. So we need a searchbox to filter results at /questions, You can use the filter query param for this, refer to backend code/JSONAPI spec for details.

firefinchdev commented 6 years ago

Done #5 @abhishek97 Pls Review

vibhorgupta-gh commented 6 years ago

@abhishek97 Figured it out, thanks a lot :D

One issue though, after logging in, when I click on the questions tab it logs me out of the session. I can see the request logging in the console, it calls api/logout This is after I added a question in the database myself

abhishek97 commented 6 years ago

@VibhorCodecianGupta Since upsert is performed on every login with oneauth, you must manually change the entry in DB to ADMIN once you log in.

You will be logged out if you receive a 401 from api, so a USER trying to access protected resource will log him out on the frontend.

abhishek97 commented 6 years ago

@VibhorCodecianGupta Please open a separate issue if you still can't run this.