coding-blocks / trouble-maker-frontend

1 stars 22 forks source link

Update ember version #22

Open mzfr opened 5 years ago

mzfr commented 5 years ago

Fixes #17

I have tried to remove the warnings. The remaining warning is due to ember-datetime-picker

One of the warnings is

WARNING: You have not included ember-cli-shims in your project's bower.json or package.json. This only works if you provide an alternative yourself and unset app.vendorFiles['app-shims.js'].

And if we refer to issue https://github.com/ember-cli/ember-cli/issues/7327, it says we need to update the ember-cli-babel. So should I update that also?

@abhishek97 Please let me know if all the warning/deprecation error has to be removed at all cost

abhishek97 commented 5 years ago

Yes update ember-cli-babel too. Login doesn't work with this. There is an error here: https://github.com/coding-blocks/trouble-maker-frontend/blob/master/app/pods/callback/route.js#L12

I think you can fix it by

return this.get('session').authenticate('authenticator:custom', transition.to.queryParams.code)
      .then(() => this.get('currentUser').load())

notice transition.to.queryParams.codedue to api change.

abhishek97 commented 5 years ago

And of course, the project still throws some errors, so you may need to track those down too. Most common fixes include update dependency versions

mzfr commented 5 years ago

Are you talking about the linting errors?

mzfr commented 5 years ago

@abhishek97 I've updated the all the modules now. Now we are not getting the ember-cli-babel deprecated warning.

abhishek97 commented 5 years ago

@mzfr no we can ignore linting issues for now. But is the project running, do you get any errors in the browser console?

mzfr commented 5 years ago

@abhishek97 Yes, the project seems to be running and No I don't see any error but yes there are few deprecation warnings.

mzfr commented 5 years ago

@abhishek97 What do I need to do in this?

mzfr commented 5 years ago

@abhishek97 Anything else to be done?