search

coding-pot / Zero2Story

Zero2Story
MIT License
146 stars 18 forks source link

Founded typos. #36

Closed kangyeolk closed 1 year ago

kangyeolk commented 1 year ago

Hi, thank you for sharing this awesome work! In background prompt part, the description and the example are different.

https://github.com/coding-pot/Zero2Story/blob/b93da7db9462b2fa2bd4b9dc479b955b15fec0ce/assets/palm_prompts.toml#L58

https://github.com/coding-pot/Zero2Story/blob/b93da7db9462b2fa2bd4b9dc479b955b15fec0ce/assets/palm_prompts.toml#L77

It should be modified as the same naming: main_sentence or primary_sentence

jphan32 commented 1 year ago

Thank you for identifying and reporting the issue.