search

codingMustache / zshMusic

An Apple Music CLI tool to control your apple Music through the terminal.
MIT License
59 stars 25 forks source link

Conflicts with OhMyZsh macos plugin #1

Open doctorfree opened 11 months ago

doctorfree commented 11 months ago

I love this kind of thing. Good work.

However, the music function already exists in the macos plugin for Zssh at https://github.com/ohmyzsh/ohmyzsh/tree/master/plugins/macos

I was able to simply change music to amusic in zshMusic.zsh to get it to work.

I would recommend either renaming the music function so it does not conflict with a popular OhMyZsh plugin or contributing your work to the macos plugin as it looks like yours has more functionality.

Also, there is a typo in tthe README - source ~/add-to-your-.zshrc/zshMusic/zshmusic.zsh should be source ~/add-to-your-.zshrc/zshMusic/zshMusic.zsh (capitalize the M).

Thanks for this cool tool!

codingMustache commented 2 months ago

Yea thats a really good idea, I'll change it to zmusic. Would that work?