codingcyclist / ha_strava

Pipe your Activity Data from Strava directly into Home Assistant
MIT License
76 stars 29 forks source link

Requirements in manifest.json #28

Open badguy99 opened 3 years ago

badguy99 commented 3 years ago

Would it be possible to change the requirements in the manifest.json file to be: "requirements": ["aiohttp>=3.6.1", "voluptuous>=0.11.7"],

i.e. >= rather than == as Home Assistant core already includes these packages but at a higher version - https://github.com/home-assistant/core/blob/dev/requirements.txt - so it would save having to install the older versions as well. It seems to work fine like this.

And just as a heads up, a version will be required in the manifest.json soon too - https://developers.home-assistant.io/blog/2021/01/29/custom-integration-changes#versions